Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new Gemini model 'gemini-2.0-flash-exp' #223

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add support for new Gemini model 'gemini-2.0-flash-exp' #223

merged 3 commits into from
Dec 12, 2024

Conversation

Etelis
Copy link
Contributor

@Etelis Etelis commented Dec 12, 2024

Introduce the new Gemini model to the existing model list.
address issue #216

An easy fix.

@janas-adam
Copy link
Contributor

checked, works well

@Etelis
Copy link
Contributor Author

Etelis commented Dec 12, 2024

checked, works well

Thanks!
Just saw your message on the issue itself.
maybe we could jointly work on this.
you could add tests related to it for instance (if you feel like doing so)

@sydney-runkle
Copy link
Member

@Etelis,

Could you please add this to pydantic_ai.models.__init__.py as well? Should just be a one line addition. LGTM otherwise, thanks!

@Etelis
Copy link
Contributor Author

Etelis commented Dec 12, 2024

@Etelis,

Could you please add this to pydantic_ai.models.__init__.py as well? Should just be a one line addition. LGTM otherwise, thanks!

Yeah sure, added.
must have missed that.

@sydney-runkle sydney-runkle added the new models Support for new model(s) label Dec 12, 2024
sydney-runkle
sydney-runkle approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sydney-runkle sydney-runkle merged commit 560ecb2 into pydantic:main Dec 12, 2024
13 checks passed
@Etelis Etelis deleted the model/add-gemini-2-0 branch December 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
new models Support for new model(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Etelis @janas-adam @sydney-runkle