-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ModelSettings
logic
#227
Conversation
Deploying pydantic-ai with Cloudflare Pages
|
ModelRequestSettings
logicModelSettings
logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Ii]nherited_members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
…dantic-ai into model-runtime-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looking good. we need to add docs, and make sure all models are respecting all relevant settings.
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
What docs would you like me to add beyond the existing conceptual and API docs? Apologies, I had an outdated comment in the description indicating docs were still needed, but I added some late yesterday. |
This PR adds support for a
model_settings
argument torun
calls, as well asAgent
initialization to specify model settings liketemperature
,timeout
, etc. We anticipate further developing this structure in the future with more specs.In the future, we'd consider adding a
model_specific
key to aid in specifying settings for specific models, likeanthropic
oropenai