-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove older deprecated models of Anthropic #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove older deprecated models of Anthropic #2345
Conversation
|
@medaminezghal Thanks Mohamed! |
|
Why do this? |
|
@alexmojaki These model names will still work, but by removing them from this Literal type, they will no longer be suggested as values for the |
|
And why restrict the version of anthropic? |
|
@alexmojaki Good point, I'll revert that. @medaminezghal For future reference, we want to be on the lowest possible version that works with Pydantic AI, meaning we should only update when relevant bugs get fixed or new features get added that we use. |
|
@DouweM @alexmojaki according to this documentation, the models removed are retired, only Sorry, I didn't mention this in the description. I think this commit shouldn't be reverted. |
|
@medaminezghal I reverted it because there's no particular reason to require users to update the |
|
@DouweM Even with old versions, |
|
Isn't it possible to remove the model names without bumping the anthropic version? |
|
@alexmojaki this will cause problem in tests. |
|
@alexmojaki The model names are coming from a constant from the anthropic package, so we could manually filter them out, but there's honestly no real harm in having them. I'd be more inclined to update |
This will remove the
deprecated modelsofAnthropicin version0.59.0bythis commit