feat: add optional base_url kwarg to OpenAIModel #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambarnes
force-pushed
the
sam/openaimodel-base_url
branch
from
3b8a981 to
495d1a8
Compare
|
docs running locally:
|
dmontagu
approved these changes
Dec 13, 2024
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hihi ✌️ regarding the short exchange over on this issue:
#215 (comment)
noticed that the proposed syntax wasnt actually available on OpenAIModel yet, so i figured that's the PR you meant you'd be open to?
if you'd rather not introduce the API addition rn, i also have a purely docs change in this branch:
main...sambarnes:pydantic-ai:sam/openrouter-example
totally open to driving this PR home tho if this is along the lines of what ya were thinkin :)