Change: Internal Discriminator Modification #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-ai with
|
| Latest commit: |
84e9d09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://627b5456.pydantic-ai.pages.dev |
| Branch Preview URL: | https://kind-vs-role.pydantic-ai.pages.dev |
samuelcolvin
approved these changes
Dec 14, 2024
| @@ -196,7 +196,7 @@ async def _messages_create( | |||
| anthropic_messages: list[MessageParam] = [] | |||
|
|
|||
| for m in messages: | |||
| if m.role == 'system': | |||
| if m.message_kind == 'system-prompt': | |||
There was a problem hiding this comment.
probably better to use isinstance. @dmontagu already changed it in most places.
There was a problem hiding this comment.
Good idea, will do!
|
Verifying that the chat app still works locally, then I'll merge. |
|
The chat app is actually broken on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #232 (comment), where we discussed that this change should be added to a separate PR.
This PR changes the
Messagesstructures such that each one has:message_kind: a discriminator used to identify the message typerole: either'model'or'user', like Gemini has, and similar to Anthropic's'assistant'or'user'Message parts, which are used to construct a
ModelResponsenow have apart_kinddiscriminator instead of just a plainkind.