-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: add grids, tables to make intro info easier to digest #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- Pydantic
- Groq
- Logfire
- [Vv]alidators
- Ollama
Deploying pydantic-ai with Cloudflare Pages
|
TODO in a future PR, wanted to go ahead and get this across the line :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, let's try to make this list a bit tighter still
I think it's just not working on the docs preview, it's working locally? I can dig into this though... |
@sydney-runkle I'm not super attached to the icons either, if getting rid of them helps get this across the line faster I think that's fine :) |
I think this should be ready now, I say we merge, if the icons are an issue, I'll remove 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason this isn't working in the preview but is locally is you haven't updated markdown_extensions
in mkdocs.insiders.yml
.
if you run make docs-insiders-serve
you should see the problem, generally you should always use that in development, buy you'll neeed the pppr token set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason this can't just go in img
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or in docs/img/.icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, custom icons have to go in a folder you add as the custom_dir
in mkdocs.yml
, and I didn't want to make img
that folder...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I can do that if you want!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the tip re insiders. Hadn't been building locally with those |
Interesting, not getting a warning, but I am getting the failure to render on the local serve now: (pydantic-ai) (base) programming@Sydneys-MacBook-Pro pydantic-ai % make docs-serve-insiders
insiders packages already installed
uv run --no-sync mkdocs serve -f mkdocs.insiders.yml
INFO - Building documentation...
INFO - Cleaning site directory
INFO - Documentation built in 4.07 seconds
INFO - [10:03:43] Watching paths for changes: 'docs', 'mkdocs.insiders.yml', 'pydantic_ai_slim',
'pydantic_ai_examples'
INFO - [10:03:43] Serving on http://127.0.0.1:8000/ |
Fixed, thanks for the tip! Forgot about |
Before:
After:
Before:
After: