Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add grids, tables to make intro info easier to digest #276

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Dec 16, 2024

  • More engaging "why PydanticAI" section with icons and headings
  • Move glossary on agents page to tabular format

Before:
Screenshot 2024-12-17 at 9 21 04 AM

After:
Screenshot 2024-12-17 at 6 48 56 PM

Before:
Screenshot 2024-12-17 at 9 22 32 AM

After:
Screenshot 2024-12-17 at 9 22 21 AM

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • Pydantic
  • Groq
  • Logfire
  • [Vv]alidators
  • Ollama

Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2024

Deploying pydantic-ai with  Cloudflare Pages  Cloudflare Pages

Latest commit: e83d21e
Status: ✅  Deploy successful!
Preview URL: https://1bd6e3f5.pydantic-ai.pages.dev
Branch Preview URL: https://docs-update-ease-of-use.pydantic-ai.pages.dev

View logs

@sydney-runkle
Copy link
Member Author

TODO in a future PR, wanted to go ahead and get this across the line :)

  • Break up complicated example into more digestible parts
  • Provide more context for each example, moving some information out of code annotations
  • Add admonitions giving context to agent framework terminology + linking to the relevant conceptual section
  • Add more Pydantic Logfire context

@sydney-runkle sydney-runkle marked this pull request as ready for review December 17, 2024 14:20
@sydney-runkle sydney-runkle changed the title Draft: Improving Intro Docs Page Documentation: add grids, tables to make intro info easier to digest Dec 17, 2024
@sydney-runkle sydney-runkle added the documentation Improvements or additions to documentation label Dec 17, 2024
docs/agents.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@summerscope summerscope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's try to make this list a bit tighter still

docs/agents.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Member

samuelcolvin commented Dec 18, 2024

The logfire logo isn't working

image

I'm personally still not convinced the colored icons add anything, but happy to accept that.

We should also update the root README.md.

@sydney-runkle
Copy link
Member Author

I think it's just not working on the docs preview, it's working locally? I can dig into this though...

@summerscope
Copy link
Contributor

@sydney-runkle I'm not super attached to the icons either, if getting rid of them helps get this across the line faster I think that's fine :)

@sydney-runkle
Copy link
Member Author

I think this should be ready now, I say we merge, if the icons are an issue, I'll remove 👍

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason this isn't working in the preview but is locally is you haven't updated markdown_extensions in mkdocs.insiders.yml.

if you run make docs-insiders-serve you should see the problem, generally you should always use that in development, buy you'll neeed the pppr token set.

mkdocs.yml Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this can't just go in img?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or in docs/img/.icons

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, custom icons have to go in a folder you add as the custom_dir in mkdocs.yml, and I didn't want to make img that folder...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I can do that if you want!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs.yml Outdated Show resolved Hide resolved
@sydney-runkle
Copy link
Member Author

Ah, thanks for the tip re insiders. Hadn't been building locally with those

@sydney-runkle
Copy link
Member Author

sydney-runkle commented Dec 19, 2024

Interesting, not getting a warning, but I am getting the failure to render on the local serve now:

(pydantic-ai) (base) programming@Sydneys-MacBook-Pro pydantic-ai % make docs-serve-insiders
insiders packages already installed
uv run --no-sync mkdocs serve -f mkdocs.insiders.yml
INFO    -  Building documentation...
INFO    -  Cleaning site directory
INFO    -  Documentation built in 4.07 seconds
INFO    -  [10:03:43] Watching paths for changes: 'docs', 'mkdocs.insiders.yml', 'pydantic_ai_slim',
           'pydantic_ai_examples'
INFO    -  [10:03:43] Serving on http://127.0.0.1:8000/

@sydney-runkle
Copy link
Member Author

Fixed, thanks for the tip! Forgot about mkdocs.insiders.yml

@samuelcolvin samuelcolvin merged commit a390336 into main Dec 19, 2024
15 checks passed
@samuelcolvin samuelcolvin deleted the docs-update-ease-of-use branch December 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants