Allow custom provider to be passed into infer_model #3341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
reviewed
Nov 5, 2025
| def infer_model(model: Model | KnownModelName | str) -> Model: # noqa: C901 | ||
| """Infer the model from the name.""" | ||
| def infer_model( # noqa: C901 | ||
| model: Model | KnownModelName | str, provider_generator: Callable[[str], Provider[Any]] | None = None |
There was a problem hiding this comment.
"generator" has a different specific meaning in Python, so let's use "factory", and we can make the existing function the default argument value:
Suggested change
| model: Model | KnownModelName | str, provider_generator: Callable[[str], Provider[Any]] | None = None | |
| model: Model | KnownModelName | str, provider_factory: Callable[[str], Provider[Any]] = infer_provider |
Comment on lines
+718
to
+720
| if provider_generator is None: | ||
| provider_generator = infer_provider | ||
| provider = provider_generator(provider_name) |
There was a problem hiding this comment.
Suggested change
| if provider_generator is None: | |
| provider_generator = infer_provider | |
| provider = provider_generator(provider_name) | |
| provider = provider_factory(provider_name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3163 based on feedback in #3185