Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistral optimised #396

Merged
merged 22 commits into from
Dec 23, 2024
Merged

Mistral optimised #396

merged 22 commits into from
Dec 23, 2024

Conversation

YanSte
Copy link
Contributor

@YanSte YanSte commented Dec 17, 2024

Changes Made:

  1. Removed json-repair Library:

    • Removing the json-repair library simplifies the codebase and reduces the number of imported libraries.
    • The JSON mode returns segmented JSON, which only requires proper closing.
    • Added a Simple pydantic_core.from_json that handles closing.
  2. Added Tests:

    • Implemented tests using the basemodel to validate required parameters.

Sample Notebook

@YanSte YanSte changed the title WIP // Mistral optimised [WIP] Mistral optimised Dec 17, 2024
@YanSte YanSte changed the title [WIP] Mistral optimised Mistral optimised Dec 18, 2024
@YanSte YanSte marked this pull request as draft December 18, 2024 18:49
@YanSte YanSte marked this pull request as ready for review December 18, 2024 21:17
@YanSte YanSte requested a review from dmontagu December 19, 2024 11:19
@dmontagu dmontagu merged commit d24d183 into pydantic:main Dec 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants