Add support for usage limits #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-ai with
|
| Latest commit: |
849cbfe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3553c835.pydantic-ai.pages.dev |
| Branch Preview URL: | https://usage-limits.pydantic-ai.pages.dev |
samuelcolvin
approved these changes
Dec 18, 2024
dmontagu
force-pushed
the
usage-limits
branch
from
a736ed8 to
24ff889
Compare
dmontagu
commented
Dec 18, 2024
dmontagu
commented
Dec 18, 2024
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
|
Once this is merged let's create an issue talking about related improvements we might make:
I don't think we want to do either of those things unconditionally, but it's probably worth creating a tracking issue for discussion about whether/how to make such changes |
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
UsageLimitsand raise errors when they are exceeded.This could use more tests before merging, I wouldn't say I'm confident it is working properly in all cases yet. But I'm also not confident enough in the approach to really want to put a lot more effort into testing yet. (Though I'll note I did already add one simple test, and updated the FunctionModel and TestModel to track token counts in the usage.)
Also needs docs.