use RunContext more widely
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
reuse-run_ctx
branch
from
e22ffa9 to
023f5a8
Compare
Deploying pydantic-ai with
|
| Latest commit: |
39508d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f99a7f1c.pydantic-ai.pages.dev |
| Branch Preview URL: | https://reuse-run-ctx.pydantic-ai.pages.dev |
| tool_call: _messages.ToolCallPart | None, | ||
| messages: list[_messages.ModelMessage], | ||
| run_ctx: RunContext[AgentDeps], |
There was a problem hiding this comment.
We call this ctx in our examples, should we be consistent and to that here?
There was a problem hiding this comment.
Or maybe we could just fully use run_context?
There was a problem hiding this comment.
yes, probably run_context internally is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
modeltoRunContext.This was part of my new agent handoff work, but I decided to spit it out.