Prioritize tool calls over eager text responses #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-ai with
|
| Latest commit: |
6f9670f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f739a933.pydantic-ai.pages.dev |
| Branch Preview URL: | https://fix-mixed-tool-text-response.pydantic-ai.pages.dev |
sydney-runkle
changed the title
dmontagu
reviewed
Dec 20, 2024
dmontagu
approved these changes
Dec 20, 2024
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
…dantic/pydantic-ai into fix-mixed-tool-text-responses
| system_prompt='Be concise, reply with one sentence.', | ||
| system_prompt=( | ||
| 'Be concise, reply with one sentence.' | ||
| 'Use the `get_lat_lng` tool to get the latitude and longitude of the locations, ' |
There was a problem hiding this comment.
I think it's worth having a comment here saying
''Be concise, reply with one sentence.' is enough for some models like openAI, but Gemini in particular needs this explicit prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #268
Fix #363
Fix #510