Reorganize examples #507
Merged
Reorganize examples #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I won't be surprised if I need to update some docs references or something, either way I wanted to open this PR as a reminder to look into this all more carefully.) |
sydney-runkle
added
documentation
|
Seems reasonable but looks like we've got a docs failure? |
Deploying pydantic-ai with
|
| Latest commit: |
539f965
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9af6dc4b.pydantic-ai.pages.dev |
| Branch Preview URL: | https://dmontagu-reorganize-examples.pydantic-ai.pages.dev |
samuelcolvin
force-pushed
the
dmontagu/reorganize-examples
branch
from
f764803 to
a4fc5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there's a reason we didn't use the same structure for the examples folder that we use for
pydantic_ai_slim, but there was some confusion on slack and issues with it not being treated as a package, in particular, some of the commands to run things didn't work unless you removed thepydantic_ai_examplesfrom the start of the module name references.If this change works, I think it's fine. If there's a reason it's problematic, we can close this PR, but probably a good idea to try to resolve the original issue. See this thread for more details: https://pydanticlogfire.slack.com/archives/C083V7PMHHA/p1734643821267229