add a default to ResultData, some related cleanup
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-ai with
|
| Latest commit: |
c5d06d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6bdff681.pydantic-ai.pages.dev |
| Branch Preview URL: | https://resultdata-default.pydantic-ai.pages.dev |
| @@ -178,6 +178,13 @@ def run_sync3() -> None: | |||
| assert_type(result.data, Union[Foo, Bar]) | |||
|
|
|||
|
|
|||
| MyUnion: TypeAlias = 'Foo | Bar' | |||
| union_agent2: Agent[None, MyUnion] = Agent( | |||
| result_type=MyUnion, # type: ignore[arg-type] | |||
There was a problem hiding this comment.
Why do we need the type ignore here? What's the error?
There was a problem hiding this comment.
we need the type here so we can enforce the return type. The error is that a union is not a type, but a typeform, docs about waiting for PEP 747 - https://ai.pydantic.dev/results/?h=pep#structured-result-validation
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.