Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean chat_app example #553

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Clean chat_app example #553

merged 1 commit into from
Dec 27, 2024

Conversation

DurandA
Copy link
Contributor

@DurandA DurandA commented Dec 27, 2024

  • Remove unused MessageTypeAdapter
  • Use FileResponse for static content
  • Use matching conversation response CSS class

@DurandA
Clean chat_app example
826de9f 
* Remove unused `MessageTypeAdapter`
* Use `FileResponse` for static content
* Use matching conversation response CSS class
@DurandA
Copy link
Contributor Author

DurandA commented Dec 27, 2024

Let me know if you would accept to add additional dependencies to simplify the DB interface in the_chat_app_ example, e.g.:

  • aiosqlite to remove the "asyncify" stuff
  • SQLModel to remove the boilerplate but I am not sure if this will confuse users

@sydney-runkle sydney-runkle added the documentation Improvements or additions to documentation label Dec 27, 2024
sydney-runkle
sydney-runkle approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@sydney-runkle sydney-runkle merged commit e9bdb04 into pydantic:main Dec 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DurandA @sydney-runkle