-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures with PyPy3.10 7.3.12rc2 #659
Comments
On a semi-related note, if I build the extension in dev profile for debugging, it crashes on all PyPy versions, though on something else: https://foss.heptapod.net/pypy/pypy/-/issues/3948 |
@davidhewitt any idea if this is a pyo3 issue? |
Very likely. We haven't yet attempted to add pypy 3.10 dev builds to our CI, I'll try to check tomorrow if it's possible in GitHub actions, and if so, we can get a 0.19.1 out. |
They are listed on https://downloads.python.org/pypy/versions.json, so it probably should be possible. You may need to somehow indicate that you want |
Gentle ping. Does anyone happen to know if there's any progress here? |
Since #731 we now have the upstream support from PyO3 for PyPy 3.10 added in here. Also see PyO3/pyo3#2781 (reply in thread) - @adamreichold identified some possible issues related to stack overflows. I'm not sure anything was actioned here about that. |
Was that diff included here? If not, there are still two independent recursion limits used and both are too large for debug builds on PyPy. |
I was asking about these errors here:
I can still reproduce them with d08d269 (which is using PyO3 0.19.1. Debug builds are not a critical feature for us. |
Right, thanks for reraising that one. I've debugged this morning and I believe PyO3/pyo3#3297 will resolve. |
Thanks a lot! |
These seem new, compared to PyPy3.9:
Unfortunately, Rust extensions are outside my expertise, so I can't tell if it's something pydantic-core is doing, a bug in PyO3 or a bug in PyPy3.10. If you could help me determine that, I can pass it on to the correct project.
The text was updated successfully, but these errors were encountered: