Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to PyO3 0.19.1 #731

Merged
merged 2 commits into from
Jul 3, 2023
Merged

update to PyO3 0.19.1 #731

merged 2 commits into from
Jul 3, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Update PyO3 to 0.19.1 to pick up the fix for PyO3's set memory leak and support for PyPy 3.10.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #731 (a7f3643) into main (d285975) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          99       99           
  Lines       13913    13913           
  Branches       25       25           
=======================================
  Hits        13028    13028           
  Misses        879      879           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d285975...a7f3643. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2023

CodSpeed Performance Report

Merging #731 will improve performances by 11.39%

Comparing dh/pyo3-0.19.1 (a7f3643) with main (d285975)

Summary

🔥 1 improvements
✅ 125 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/pyo3-0.19.1 Change
🔥 test_set_of_ints_core_json_duplicates 5.4 ms 4.8 ms +11.39%

@davidhewitt davidhewitt merged commit d76812a into main Jul 3, 2023
@davidhewitt davidhewitt deleted the dh/pyo3-0.19.1 branch July 3, 2023 16:12
@adriangb
Copy link
Member

adriangb commented Jul 3, 2023

Can we also incorporate PyO3/pyo3#3156 to replace

impl BuildSet for &PyFrozenSet {
fn build_add(&self, item: PyObject) -> PyResult<()> {
unsafe {
py_error_on_minusone(
self.py(),
ffi::PySet_Add(self.as_ptr(), item.to_object(self.py()).as_ptr()),
)
}
}
fn build_len(&self) -> usize {
self.len()
}
}
?

@davidhewitt
Copy link
Contributor Author

Can we also incorporate PyO3/pyo3#3156 to replace

impl BuildSet for &PyFrozenSet {
fn build_add(&self, item: PyObject) -> PyResult<()> {
unsafe {
py_error_on_minusone(
self.py(),
ffi::PySet_Add(self.as_ptr(), item.to_object(self.py()).as_ptr()),
)
}
}
fn build_len(&self) -> usize {
self.len()
}
}

?

I took a look at this, but PyFrozenSetBuilder doesn't expose len(). I'll take a look at adding to PyO3 upstream, maybe when we get to PyO3 0.20 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants