Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.14.6 patch release #1128

Merged
merged 3 commits into from
Dec 21, 2023
Merged

2.14.6 patch release #1128

merged 3 commits into from
Dec 21, 2023

Conversation

davidhewitt
Copy link
Contributor

Cherry-pick of #1125 onto 2.14 branch.

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #1128 (126a165) into 2.14 (82158ce) will decrease coverage by 0.64%.
The diff coverage is 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.14    #1128      +/-   ##
==========================================
- Coverage   90.35%   89.71%   -0.64%     
==========================================
  Files         106      106              
  Lines       17338    16407     -931     
  Branches       35       35              
==========================================
- Hits        15665    14719     -946     
- Misses       1666     1681      +15     
  Partials        7        7              
Files Coverage Δ
src/serializers/type_serializers/definitions.rs 98.57% <100.00%> (+0.08%) ⬆️
src/definitions.rs 87.96% <91.89%> (+2.47%) ⬆️
src/validators/definitions.rs 94.80% <89.28%> (+0.28%) ⬆️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82158ce...126a165. Read the comment docs.

Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #1128 will improve performances by 30.81%

Comparing dh/2.14.6 (126a165) with 2.14 (82158ce)

Summary

⚡ 1 improvements
✅ 139 untouched benchmarks

Benchmarks breakdown

Benchmark 2.14 dh/2.14.6 Change
test_core_future_str 35.3 µs 27 µs +30.81%

@davidhewitt davidhewitt merged commit 0eb9f4e into 2.14 Dec 21, 2023
62 checks passed
@davidhewitt davidhewitt deleted the dh/2.14.6 branch December 21, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant