Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow due to recursion in some recursive serializer schemas. #1198

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

dmontagu
Copy link
Collaborator

@davidhewitt thanks for the help with this

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #1198 will improve performances by 26.51%

Comparing fix-segfault-for-some-recursive-schemas (1958399) with main (ea443ba)

Summary

⚡ 3 improvements
✅ 145 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-segfault-for-some-recursive-schemas Change
test_core_future_str 39.4 µs 31.9 µs +23.58%
test_core_str 39.1 µs 31.6 µs +23.76%
test_core_future 37.7 µs 29.8 µs +26.51%

@davidhewitt davidhewitt merged commit 7fe78ed into main Feb 26, 2024
28 checks passed
@davidhewitt davidhewitt deleted the fix-segfault-for-some-recursive-schemas branch February 26, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants