Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyodide to 0.25.0 #1199

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

samdobson
Copy link
Contributor

@samdobson samdobson commented Feb 19, 2024

I needed a WASM build for the latest stable release of pyodide. Sharing the changes I made to achieve this in case helpful.

Pyodide v0.25.0 changelog

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #1199 will degrade performances by 16.82%

Comparing samdobson:pyodide-upgrade-0.25.0 (e57dd72) with main (ea443ba)

Summary

❌ 1 regressions
✅ 147 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main samdobson:pyodide-upgrade-0.25.0 Change
test_small_class_core_dict 32 µs 38.5 µs -16.82%

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@davidhewitt davidhewitt merged commit 8c6e2bd into pydantic:main Feb 20, 2024
26 of 27 checks passed
@samuelcolvin
Copy link
Member

This broke the executable docs examples which is the primary purpose of the wasm build, see samuelcolvin/mkdocs-run-code@1ef955d for the fix.

The problem is that https://github.com/samuelcolvin/mkdocs-run-code has to know (or guess at) the platform, e.g. emscripten_3_1_32_wasm32 or emscripten_3_1_46_wasm32.

In future if we change the emscripten version, we should update there too.

@riyavsinha riyavsinha mentioned this pull request Oct 28, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants