Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml to get a 'Summary' metadata #1214

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

stonebig
Copy link
Contributor

@stonebig stonebig commented Mar 3, 2024

Change Summary

Provide Summary Metadata, as pydantic-core is in the 1% of packages that I use and that miss one

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Merging #1214 (5d64319) into main (ab503cb) will increase coverage by 0.01%.
Report is 20 commits behind head on main.
The diff coverage is n/a.

❗ Current head 5d64319 differs from pull request most recent head 1640071. Consider uploading reports for the commit 1640071 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   90.21%   90.22%   +0.01%     
==========================================
  Files         106      106              
  Lines       16339    16385      +46     
  Branches       36       36              
==========================================
+ Hits        14740    14784      +44     
- Misses       1592     1594       +2     
  Partials        7        7              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe78ed...1640071. Read the comment docs.

Copy link

codspeed-hq bot commented Mar 3, 2024

CodSpeed Performance Report

Merging #1214 will degrade performances by 16.43%

Comparing stonebig:patch-1 (1640071) with main (7fe78ed)

Summary

❌ 1 regressions
✅ 147 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main stonebig:patch-1 Change
test_small_class_core_dict 32.3 µs 38.6 µs -16.43%

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable to me!

pyproject.toml Outdated Show resolved Hide resolved
@davidhewitt davidhewitt enabled auto-merge (squash) March 4, 2024 13:51
@davidhewitt davidhewitt merged commit ad5007d into pydantic:main Mar 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants