Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PEP570 syntax #1216

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Use PEP570 syntax #1216

merged 1 commit into from
Mar 5, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 5, 2024

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@davidhewitt davidhewitt enabled auto-merge (squash) March 5, 2024 17:23
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #1216 (9a83305) into main (ab503cb) will increase coverage by 0.01%.
Report is 26 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
+ Coverage   90.21%   90.22%   +0.01%     
==========================================
  Files         106      106              
  Lines       16339    16373      +34     
  Branches       36       39       +3     
==========================================
+ Hits        14740    14773      +33     
+ Misses       1592     1581      -11     
- Partials        7       19      +12     
Files Coverage Δ
python/pydantic_core/core_schema.py 94.69% <ø> (-0.08%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98b8b0...9a83305. Read the comment docs.

@davidhewitt davidhewitt merged commit f669db9 into pydantic:main Mar 5, 2024
27 checks passed
Copy link

codspeed-hq bot commented Mar 5, 2024

CodSpeed Performance Report

Merging #1216 will not alter performance

Comparing Viicos:pep-570 (9a83305) with main (a98b8b0)

Summary

✅ 148 untouched benchmarks

@Viicos Viicos deleted the pep-570 branch March 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants