Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass in 2032 #1221

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Make tests pass in 2032 #1221

merged 1 commit into from
Mar 12, 2024

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Mar 12, 2024

Change Summary

Make tests pass in 2032

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +16 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +16 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.
@bmwiedemann
Copy link
Contributor Author

please review

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #1221 (779afa8) into main (ab503cb) will decrease coverage by 0.36%.
Report is 29 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
- Coverage   90.21%   89.86%   -0.36%     
==========================================
  Files         106      106              
  Lines       16339    16474     +135     
  Branches       36       40       +4     
==========================================
+ Hits        14740    14804      +64     
- Misses       1592     1651      +59     
- Partials        7       19      +12     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1083986...779afa8. Read the comment docs.

Copy link

codspeed-hq bot commented Mar 12, 2024

CodSpeed Performance Report

Merging #1221 will improve performances by 15.21%

Comparing bmwiedemann:main (779afa8) with main (1083986)

Summary

⚡ 1 improvements
✅ 147 untouched benchmarks

Benchmarks breakdown

Benchmark main bmwiedemann:main Change
test_core_future 55 µs 47.7 µs +15.21%

@davidhewitt davidhewitt merged commit 4a533aa into pydantic:main Mar 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants