Fix json serialization when computed field is excluded #1228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pydantic/pydantic#9015
Previously, we were getting the value of a computed field before we checked if it was excluded, which could lead to a recursion error in a case like that shown below.
This mirrors the behavior of the
to_python
logic already present, which currently works.This case is now fixed, and prints the id as expected! I think it makes sense to add a test case in
pydantic
for this 👍Selected Reviewer: @samuelcolvin