really drop python<=3.7 support #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter all code over `pyupgrade --py38`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
CodSpeed Performance ReportMerging #1232 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Thanks, looks good to me! Just a couple of lint warnings arising from this:
ruff check python/pydantic_core tests generate_self_schema.py wasm-preview/run_tests.py
tests/validators/test_date.py:6:25: F401 [*] `typing.Dict` imported but unused
tests/validators/test_decimal.py:7:25: F401 [*] `typing.Dict` imported but unused
Found 2 errors.
|
I have difficulties with locating what generates those to try to understand about those errors are 🤔 |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Filter all code over
pyupgrade --py38.Checklist
pydantic-core(except for expected changes)