trim leading zeros before parsing str
-> int
#1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Trim leading zeros as well as other cleaning while coercing strings to ints.
Prior to #1250 we used
str.parse::<i64>()
andstr.parse::<BigInt>()
to coerce strings to integers, in #1250 we adopting the integer parsing logic from jiter (e.g. the logic we use to build integers from JSON strings), in JSON0001
isn't a valid number, but I was unaware thatstr.parse::<i64>()
did allow it, hence the break.With this change we stripe leading zeros as part of other cleaning like striping whitespace, stripping
.0+
, and removing single underscores within the string.Related issue number
Fix pydantic/pydantic#9165
Checklist
pydantic-core
(except for expected changes)