Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate_self_schema for Python 3.12+ #1299

Merged
merged 1 commit into from
May 22, 2024

Conversation

JelleZijlstra
Copy link
Contributor

For reference: https://github.com/python/cpython/blob/8c96850161da23ad2b37551d2a89c7d4716fe024/Lib/typing.py#L916

Ran into this trying to install pydantic on 3.14.

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented May 22, 2024

CodSpeed Performance Report

Merging #1299 will not alter performance

Comparing JelleZijlstra:patch-1 (e4deb7e) with main (88a8a30)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Looks good to me!

@sydney-runkle sydney-runkle merged commit a762041 into pydantic:main May 22, 2024
28 checks passed
@davidhewitt
Copy link
Contributor

@JelleZijlstra it's worth noting that I have no idea what parts may be broken under 3.14 due to the PyO3 layer - we can try to add patches to PyO3 if needed but hopefully the majority works. If in doubt you might want to try this branch which at least attempts to catch up with 3.13: PyO3/pyo3#4184

@JelleZijlstra
Copy link
Contributor Author

Thanks! Yes, when I tried locally I got an error telling me to use an env var that tries to use the stable ABI, but then I got the error that this PR fixes. I'll look into it some more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants