-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generate_self_schema for Python 3.12+ #1299
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1299 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! Looks good to me!
@JelleZijlstra it's worth noting that I have no idea what parts may be broken under 3.14 due to the PyO3 layer - we can try to add patches to PyO3 if needed but hopefully the majority works. If in doubt you might want to try this branch which at least attempts to catch up with 3.13: PyO3/pyo3#4184 |
Thanks! Yes, when I tried locally I got an error telling me to use an env var that tries to use the stable ABI, but then I got the error that this PR fixes. I'll look into it some more later. |
For reference: https://github.com/python/cpython/blob/8c96850161da23ad2b37551d2a89c7d4716fe024/Lib/typing.py#L916
Ran into this trying to install pydantic on 3.14.
Change Summary
Related issue number
Checklist
pydantic-core
(except for expected changes)