Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allow_partial='trailing-strings' #1390

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Support allow_partial='trailing-strings' #1390

merged 3 commits into from
Aug 5, 2024

Conversation

sydney-runkle
Copy link
Member

Implementing support for pydantic/jiter#101

@willbakst :)

davidhewitt
davidhewitt approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to clean up cache_strings at the same time 👍

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1390 will not alter performance

Comparing trailing-strings (79a0e92) with main (cc2c46c)

Summary

✅ 155 untouched benchmarks

samuelcolvin
samuelcolvin approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this matches the jiter-python signature, LGTM.

@sydney-runkle sydney-runkle merged commit 099a8e1 into main Aug 5, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the trailing-strings branch August 5, 2024 14:01
@vasudev-gm vasudev-gm mentioned this pull request Aug 12, 2024
Closed
@vasudev-gm vasudev-gm mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydney-runkle @davidhewitt @samuelcolvin