Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use little endian int (#1372)" #1393

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Revert "use little endian int (#1372)" #1393

merged 1 commit into from
Aug 5, 2024

Conversation

sydney-runkle
Copy link
Member

This reverts commit cb696e2.

@sydney-runkle sydney-runkle added the Full Build cause CI to do a full build label Aug 5, 2024
davidhewitt
davidhewitt approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending successful full build (we believe that PyO3 0.22.1 fixed a bug in the u128 extraction, which resulted in this patch being inserted originally).

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #1393 will not alter performance

Comparing revert-int-thing (c60e050) with main (81106d9)

Summary

✅ 155 untouched benchmarks

@sydney-runkle
Copy link
Member Author

Will wait until everything is done, but looks good 👍

@sydney-runkle sydney-runkle merged commit f79d49b into main Aug 5, 2024
60 of 61 checks passed
@sydney-runkle sydney-runkle deleted the revert-int-thing branch August 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
Full Build cause CI to do a full build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-runkle @davidhewitt