-
Notifications
You must be signed in to change notification settings - Fork 312
Use UserWarning from pyo3 #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #1559 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
- Coverage 90.21% 89.63% -0.59%
==========================================
Files 106 112 +6
Lines 16339 17889 +1550
Branches 36 40 +4
==========================================
+ Hits 14740 16034 +1294
- Misses 1592 1835 +243
- Partials 7 20 +13
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up 👍
Original-commit-hash: be87e05
Original-commit-link: pydantic/pydantic-core@be87e05
Change Summary
Following David's comment: #1551 (review)
Replacing the explicitly imported python
UserWarningwithPyUserWarningfrom pyo3. This might slightly improve performance in this case, depending on how pyo3 actually raises warnings. In the worst case it should be the same as the current implementation, so there's no harm doing this.Related issue number
None.
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @sydney-runkle