Add ensure_ascii option
#1689
Open
Add ensure_ascii option
#1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Apr 11, 2025
| } | ||
| } | ||
|
|
||
| macro_rules! defer { |
There was a problem hiding this comment.
As per @cetra3's suggestion. The match statement in to_json_bytes isn't going to scale well, so maybe an alternative API should be used in the future.
CodSpeed Performance ReportMerging #1689 will not alter performanceComparing Summary
|
Viicos
commented
Apr 11, 2025
| }; | ||
| } | ||
|
|
||
| #[allow(clippy::needless_lifetimes)] |
There was a problem hiding this comment.
Looks like a false positive from Clippy? There are already a bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Part of pydantic/pydantic#11202.
Related issue number
Checklist
pydantic-core(except for expected changes)