move check from Extra to SerializationState
#1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
reviewed
Oct 27, 2025
| warnings: self.warnings.clone(), | ||
| rec_guard: self.rec_guard.clone(), | ||
| config: self.config, | ||
| model: self.model.as_ref().map(|m| m.bind(py).clone()), |
Member
There was a problem hiding this comment.
Was this missed from the previous release?
Contributor
Author
There was a problem hiding this comment.
Ah no I just moved it up a few lines so that this matches the order the fields are defined in the struct.
Viicos
approved these changes
Oct 27, 2025
CodSpeed Performance ReportMerging #1862 will degrade performances by 11.79%Comparing Summary
Benchmarks breakdown
|
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Nov 5, 2025
…core#1862) Original-commit-link: pydantic/pydantic-core@3359241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The last value in
Extrawhich changes, now moved toSerializationState.With this done, I can make a follow-up where
Extrabecomes a constant value insideSerializationState, which will mean onlystateneeds to get passed around and everything possibly relevant is contained within it.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)