Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List as enum #54

Merged
merged 10 commits into from
May 11, 2022
Merged

List as enum #54

merged 10 commits into from
May 11, 2022

Conversation

samuelcolvin
Copy link
Member

continuation of #35 (comment)

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #54 (ef333ab) into main (9a4864b) will increase coverage by 0.70%.
The diff coverage is 93.71%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   87.97%   88.68%   +0.70%     
==========================================
  Files          32       32              
  Lines        2495     2571      +76     
==========================================
+ Hits         2195     2280      +85     
+ Misses        300      291       -9     
Impacted Files Coverage Δ
src/input/input_json.rs 68.03% <66.66%> (ø)
src/validators/dict.rs 77.10% <80.95%> (+1.79%) ⬆️
src/input/generics.rs 95.08% <97.08%> (+7.58%) ⬆️
src/input/input_abstract.rs 100.00% <100.00%> (ø)
src/input/input_python.rs 86.36% <100.00%> (+4.54%) ⬆️
src/validators/list.rs 78.48% <100.00%> (+1.26%) ⬆️
src/validators/model.rs 88.95% <100.00%> (ø)
src/validators/set.rs 97.46% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4864b...ef333ab. Read the comment docs.

@samuelcolvin samuelcolvin marked this pull request as ready for review May 10, 2022 14:20
@samuelcolvin samuelcolvin merged commit 69098c4 into main May 11, 2022
@samuelcolvin samuelcolvin deleted the list-as-enum branch May 11, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant