-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use from __future__ import annotations
instead of string type hints in python/pydantic_core/_pydantic_core.pyi
#710
Conversation
please review |
fef791c
to
efbad65
Compare
CodSpeed Performance ReportMerging #710 Summary
Benchmarks breakdown
|
@samuelcolvin @davidhewitt something seems to be wrong with the benchmarks now, this PR should not be changing any performance. I've rebased it onto 703b7b2 so it shouldn't be a base issue. |
This particular benchmark has been flipping up and down for a while. I'm not sure of the exact reason for it, whether the optimizer or LTO is introducing some randomness or codspeed's measurement has some volatility. |
One thought I have is that using PGO i.e. #678 might help the optimizer always hit the good code path and thus avoid the randomness. |
The lint error should be fixed by #711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double-checked the docs build after this change, looks good 👍
Seems like your approval won’t cut it, I guess we need to add you to CODEOWNERS or something |
Nope it was the lint error |
… in `python/pydantic_core/_pydantic_core.pyi`
efbad65
to
8c7f0be
Compare
Rebased, let's see if it goes in now. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 99 99
Lines 13838 13838
Branches 25 25
=======================================
Hits 12968 12968
Misses 864 864
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
Selected Reviewer: @davidhewitt