Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build-pgo make target #741

Merged
merged 3 commits into from
Jul 6, 2023
Merged

add build-pgo make target #741

merged 3 commits into from
Jul 6, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 4, 2023

Change Summary

Adds make build-pgo target, as requested in #678 (comment)

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

Makefile Show resolved Hide resolved
@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #741 (6b357d3) into main (d08d269) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   93.63%   93.64%   +0.01%     
==========================================
  Files          99       99              
  Lines       13895    13929      +34     
  Branches       25       25              
==========================================
+ Hits        13010    13044      +34     
  Misses        879      879              
  Partials        6        6              

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08d269...6b357d3. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 4, 2023

CodSpeed Performance Report

Merging #741 will not alter performances

Comparing dh/make-pgo (6b357d3) with main (d08d269)

Summary

✅ 126 untouched benchmarks

@davidhewitt
Copy link
Contributor Author

I pushed another commit which switches automatically to use maturin if the conditions look suitable (a virtualenv is active and maturin is installed), @adriangb confirmed on slack this is working so I'll merge now.

@davidhewitt davidhewitt merged commit 634087a into main Jul 6, 2023
@davidhewitt davidhewitt deleted the dh/make-pgo branch July 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants