use __new__ in .pyi for Rust types #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Follow up promised from #702 (comment)
The motivation is that the PyO3 types actually define
__new__
, not__init__
, so that's what we should document in the.pyi
. I checked with mypy and vscode and the type inference of the constructor seems to work just as well with__new__
.Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @adriangb