Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to with_prefix_location #99

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jun 20, 2022

as suggested by @afetisov in #35

Profiled this and it seems to make a 1% improvement in the case of lots of errors.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #99 (b5ccad9) into main (f26af27) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   95.87%   95.88%           
=======================================
  Files          40       40           
  Lines        3491     3497    +6     
  Branches       28       28           
=======================================
+ Hits         3347     3353    +6     
  Misses        144      144           
Impacted Files Coverage Δ
src/errors/line_error.rs 97.53% <100.00%> (-0.18%) ⬇️
src/input/generics.rs 96.42% <100.00%> (+0.20%) ⬆️
src/input/to_loc_item.rs 95.45% <100.00%> (+0.71%) ⬆️
src/validators/dict.rs 94.94% <100.00%> (+0.05%) ⬆️
src/validators/model.rs 95.07% <100.00%> (-0.03%) ⬇️
src/validators/tuple.rs 98.51% <100.00%> (+0.03%) ⬆️
src/validators/union.rs 97.22% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26af27...b5ccad9. Read the comment docs.

@samuelcolvin samuelcolvin marked this pull request as ready for review June 20, 2022 23:29
@samuelcolvin
Copy link
Member Author

merging this, but happy to accept more changes if suggested.

@samuelcolvin samuelcolvin merged commit e1b75cf into main Jun 21, 2022
@samuelcolvin samuelcolvin deleted the improve-with_prefix_location branch June 21, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant