Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule view not showing links to talks #68

Closed
codersquid opened this issue May 27, 2015 · 4 comments
Closed

Schedule view not showing links to talks #68

codersquid opened this issue May 27, 2015 · 4 comments
Assignees

Comments

@codersquid
Copy link
Member

I haven't had time to dig in to this but maybe someone could pick it up if I don't get to it soon. The schedule view isn't showing talk titles or linking to them.

weird_schedule

@codersquid
Copy link
Member Author

The lack of links is probably due to the hardcoded "talk" "tutorial" in the template here

https://github.com/pydata/conf_site/blob/master/conf_site/templates/schedule/_grid.html#L16

I think in the scipy repo we changed the model to have a property to use in the conditional, but can't remember exactly. I'll check in to it tonight. This part is trivial to fix, I think.

I'm not sure what is causes the table to render that way, however.

@codersquid
Copy link
Member Author

This comment should fix the link display, 5015bd4

I'll deploy it later, unless someone reviews, merges, and deploys it before I get to it.

gridfix

@codersquid
Copy link
Member Author

this is fixed and you can see the links on the seattle site by visiting http://seattle.pydata.org/schedule/

I'll not hook that up to the site nav unless it is acceptable.

@lsilen
Copy link

lsilen commented May 28, 2015

The links look good. Thanks @codersquid!

On May 27, 2015, at 11:18 PM, Sheila Miguez notifications@github.com wrote:

this is fixed and you can see the links on the seattle site by visiting http://seattle.pydata.org/schedule/ http://seattle.pydata.org/schedule/
I'll not hook that up to the site nav unless it is acceptable.


Reply to this email directly or view it on GitHub #68 (comment).


Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
leah@numfocus.org
512-222-5449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants