Merge pull request #475 from bashtage/morningstar-bug-column-order

BUG: Fix order of columns in morningstar
pydata · Jan 23, 2018 · 39b5b16 · 39b5b16
2 parents 9e9d63c + b657e30
commit 39b5b16
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pandas_datareader/mstar/daily.py b/pandas_datareader/mstar/daily.py
@@ -172,9 +172,8 @@ def _restruct_json(self, symbol, jsondata):
             bar = pricedata[p]
             d = next(date_)
             bardict = {
-                "Symbol": symbol, "Date": d, "Open": bar[0], "High": bar[1],
-                "Low": bar[2],
-                "Close": bar[3]
+                "Symbol": symbol, "Date": d, "Close": bar[0], "High": bar[1],
+                "Low": bar[2], "Open": bar[3]
             }
             if len(divdata) == 0:
                 pass

diff --git a/pandas_datareader/tests/mstar/test_daily.py b/pandas_datareader/tests/mstar/test_daily.py
@@ -38,7 +38,7 @@ def test_mstar(self):
         start = datetime(2014, 3, 5)
         end = datetime(2018, 1, 18)
         df = web.DataReader('MSFT', 'morningstar', start=start, end=end)
-        assert (df['Close'][-1] == 89.8)
+        assert (df['Open'][-1] == 89.8)
 
     @skip_on_exception(RemoteDataError)
     def test_get_data_single_symbol(self):
@@ -114,7 +114,7 @@ def test_mstar_reader_class(self):
         dr = MorningstarDailyReader(symbols="GOOG", interval="d")
         df = dr.read()
 
-        assert df.Volume[('GOOG', '2017-12-13')] == 1279659
+        assert df.Close[('GOOG', '2017-12-13')] == 1040.61
 
         session = requests.Session()