Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS 0.6.0 #453

Closed
2 tasks done
bashtage opened this issue Jan 18, 2018 · 24 comments
Closed
2 tasks done

RLS 0.6.0 #453

bashtage opened this issue Jan 18, 2018 · 24 comments

Comments

@bashtage
Copy link
Contributor

bashtage commented Jan 18, 2018

There have been a lot of changes in the past few days.

Please report any issues here. I there are none raised by the start of next week, 0.6.0 will be released then.

  • Add release date to what's new
  • Tag release
@bashtage
Copy link
Contributor Author

closes #420

@rsvp
Copy link

rsvp commented Jan 19, 2018

Will the deprecation messages for
yahoo-finance and google-finance
suggest alternatives means of obtaining
equities data? What are the fallback plans
for pandas_datareader?

@bashtage
Copy link
Contributor Author

bashtage commented Jan 19, 2018

They don't now. Open to suggestions -- PRs to improve the messages are welcome.

FWIW google finance isn't deprecated. Only google options and google quotes.

@bashtage
Copy link
Contributor Author

@jreback I need some help setting up doctr to build the docs and host on gh-pages. This is simpler than using RTD and also solves the issue of needed API keys which can be encrypted. I don't have admin so I can't complete the commands myself.

Also, who is the uploader to PyPi?

Would like to be able to release by early next week.

@bashtage
Copy link
Contributor Author

@davidastephens so you manage the PyPI and RTD? If so, will you be able to push a release after I tag it next week?

@jreback
Copy link
Contributor

jreback commented Jan 19, 2018

@bashtage I think @TomAugspurger or @jorisvandenbossche might be able to help with doctr

@davidastephens
Copy link
Member

@bashtage Yes, I can push a release next week. Thanks for cleaning it up.

@bashtage
Copy link
Contributor Author

@TomAugspurger and @jorisvandenbossche could you run doctr configure against master and submit a PR with the keyfile? It will be much easier to build for gh-pages than using RTD when API keys. I can't figure out a method to store API keys on RTD.

@bashtage
Copy link
Contributor Author

I'm ready to release 0.6.0, but need to get doctr setup beore doing this since docs are only pushed to gh-pages on tags.

@jorisvandenbossche
Copy link
Member

@bashtage you don't have the rights to set up doctr?

@bashtage
Copy link
Contributor Author

bashtage commented Jan 23, 2018 via email

@bashtage
Copy link
Contributor Author

Now fully ready to release, just need to get doctr sorted.

@davidastephens
Copy link
Member

Ok, so still waiting for doctr? Let me know when ready.

@bashtage
Copy link
Contributor Author

Yes, it is ready. Just need some help where someone runs

doctr configure

and then follows the instructions to commit the key file. Do you have permissions on pydata?

@davidastephens
Copy link
Member

I just tried this, I don't have permissions either. @jorisvandenbossche Do you have permissions?

@jorisvandenbossche
Copy link
Member

According to the github team I am not more a maintainer (no other role) than you @bashtage and @davidastephens
I think you have to ask @jreback (but I would also propose that @jreback adds both of you as maintainer in the pandas-datareader team, https://github.com/orgs/pydata/teams/pandas-datareader/members)

@bashtage
Copy link
Contributor Author

bashtage commented Jan 27, 2018 via email

@bashtage
Copy link
Contributor Author

bashtage commented Jan 27, 2018 via email

@jreback
Copy link
Contributor

jreback commented Jan 27, 2018

@bashtage i added you to core
i think u should have permissions now

@bashtage
Copy link
Contributor Author

bashtage commented Jan 27, 2018 via email

@bashtage
Copy link
Contributor Author

@davidastephens I tagged v0.6.0 so this should be ready for PyPI

@davidastephens
Copy link
Member

@bashtage Thanks - have pushed to PyPi.
Do you have a PyPi username? If so, I can add you as an owner.

Thanks again for cleaning this all up.

@bashtage
Copy link
Contributor Author

bashtage commented Jan 28, 2018 via email

@bashtage
Copy link
Contributor Author

@jreback I was able to do what I needed to do to get doctr setup. It might be a good idea to remove me as an owner now since I don't really need this permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants