WIP: Issue #394: Fixed google url #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the build failing? Maybe try "https" instead of "http". |
|
@rsvp No. As you can see, I have pushed a dummy commit to check if the master branch passes all tests. It does not. So that, we firstly have to fix failing tests |
|
Moved that commit to a separate PR: #403 |
|
With https I have a JSONDecodeError on google/quotes.py:30 result = json.loads(buffer[m.start() + len('// '):]) |
|
Fixed in #404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #394
WIP until tests on the master branch will be fixed: #403