Skip to content

Commit

Permalink
add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
drammock committed Jul 3, 2023
1 parent 124b761 commit 6aa43a6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,9 @@ function showVersionWarningBanner(data) {
}
const preferredVersion = preferredEntries[0].version;
const preferredURL = preferredEntries[0].url;
// TODO: make the below logic more forgiving:
// - don't fail if version string not semVer-parsable
// - if not semVer parsable make message more generic
// if already on preferred version, nothing to do
if (!version.includes("dev") && compare(version, preferredVersion, "=")) {
return;
Expand Down

0 comments on commit 6aa43a6

Please sign in to comment.