-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT - Style fixes following design system implementation #1387
Comments
Another detail that I noticed: The version dropdown is using a blue color for highlighting the "currently selected" version, while I would expect it to use the primary teal for that? (since other navigation elements use that for the current section): (although inspecting with the browser, I see the color that is being used for this in the dropdown is |
Thanks @jorisvandenbossche - I remember seeing this and leaving the colour as it was defined. But I agree it would be best to align with the rest of the theme's styles. |
agree, that is a mistake, it should be |
I am not sure if there is some historical reason for the stable version to be differentiated. But as the current style is; it is confusing and does break our current approach to indicate current/active items. Also if the version warning banners get implemented these would provide a more visible way to signal folks are not on the stable version of the docs. |
Adding more info here for completeness, it seems that something changed between the last batch of comments and what is currently in our main branch:
|
Once #1549 is merged to main (it's currently merged into a feature branch), this will be fixed |
I am opening this issue as a way to track little nags here and there that were missed through some of the accessibility-related PRs merged recently (i.e., #1174 and #1353)
If anyone encounters other nags, feel free to add to this issue or conversation 🙌🏽 feedback is always welcome!
Identified nags
Option lists style should align with inline code style
Sample images
Inline code styling:
Option lists styling:
Table of Contents: fix the link underline decoration so that it is not applied to the gap between the icon and text
Sample images
Table of contents icon + link:
An icon + link example in text:
Fix focus visible state of clickable cards - currently, the focus-visible box only appears around the bottom of the card
Sample images
Light theme only: Fix colour contrast for links on deprecation admonitions (should be fixed by using the same shade of teal as we do in the inline code links
--pst-color-inline-code-links
) - also note for @trallard to check: version added and version changed variantsSample images
The text was updated successfully, but these errors were encountered: