Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switcher styling #1400

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Update switcher styling #1400

merged 4 commits into from
Aug 8, 2023

Conversation

drammock
Copy link
Collaborator

@drammock drammock commented Aug 7, 2023

addresses some of the issues in the comments of #1387, related to the version switcher:

  • "stable" is no longer always green
  • fix mismatch between button and dropdown menu (one said "latest" other said "dev")
  • add left border (like on admonitions) to the active dropdown item, so it's status as "active" does not rely only on colour
  • changes the colour of the active item from info to primary

@drammock drammock added tag: design Items related to design tasks or improvements tag: accessibility Issues related to accessibility issues or efforts tag: UX Issues or improvements related to user experience labels Aug 7, 2023
@drammock drammock requested a review from trallard August 7, 2023 14:56
@drammock
Copy link
Collaborator Author

drammock commented Aug 7, 2023

here's a screenshot from a local build (since PR-builds always fail version-match, no item will be "active") --- note that my cursor is on the "stable" item, but isn't visible in the screenshot:

Screenshot_2023-08-07_10-16-35

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for fixing this @drammock - I left a note about using the mixin instead for consistency, and we should be able to merge.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me so will merge 🚀

@trallard trallard merged commit 0956f22 into pydata:main Aug 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: design Items related to design tasks or improvements tag: UX Issues or improvements related to user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants