-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inproper styling of dataframes for myst-nb + pydata theme when contained in ipywidget (2) #1740
Comments
Thanks for sharing this feedback @ClementPinard. |
Pinging @gabalafou who is looking into tables right now |
Ohhhh, this a deep rabbit hole. From what I can tell, there are two separate issues here:
I opened a PR (#1760) for the second issue based on what JupyterLab does. For the history of this change, see:
For the first issue, it seems to me like we need to make a decision about how we want to make ipywidgets look good on sites using PyData Sphinx theme with nbsphinx or myst-nb. We could write CSS in this repo or we could help write CSS in the ipywidgets repo. Here are a few relevant GitHub issues: |
JupyterLab PR #2737 may shine some light onto how JupyterLab styles ipywidgets for both light and dark mode |
Adjacent #745 |
This addresses one of the issues in #1740: missing horizontal scrollbar. - Add CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
This addresses one of the issues in pydata#1740: missing horizontal scrollbar. - Add CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
#1787) One of many fixes for the failing accessibility tests (see #1428). The accessibility tests were still reporting some violations of: - Scrollable region must have keyboard access (https://dequeuniversity.com/rules/axe/4.8/scrollable-region-focusable) even after merging #1636 and #1777. These were due to Jupyter notebook outputs that have scrollable content. This PR extends the functionality of PRs #1636 and #1777 to such outputs. - Adds a test for tabindex = 0 on notebook outputs after page load This also addresses one of the issues in #1740: missing horizontal scrollbar by: - Adding CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
This might have been fixed by #1787 |
This addresses one of the issues in pydata#1740: missing horizontal scrollbar. - Add CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
pydata#1787) One of many fixes for the failing accessibility tests (see pydata#1428). The accessibility tests were still reporting some violations of: - Scrollable region must have keyboard access (https://dequeuniversity.com/rules/axe/4.8/scrollable-region-focusable) even after merging pydata#1636 and pydata#1777. These were due to Jupyter notebook outputs that have scrollable content. This PR extends the functionality of PRs pydata#1636 and pydata#1777 to such outputs. - Adds a test for tabindex = 0 on notebook outputs after page load This also addresses one of the issues in pydata#1740: missing horizontal scrollbar by: - Adding CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
Hi, this is a small continuation from #1063
Last time, there was a problem with the table collapsing, this is solved now (thank you !)
Now I am in search for a solution to style the dataframe in a widget the same way as directly outputted in the cell
As you can see, the dataframe in the tab widget does not have the same color (and the widget is not dark themed as well), and more problematic, the horizontal scroll bar is gone.
Note that contrary to the last problem, this one is present in both nbconvert and nb-sphinx
Also, note that the light mode has the right dataframe colors, but still does not have the scroll bar. As such, I am not sure the scroll bar disappearing is related to pydata theme
As for the last issue, you can recreate the problem in this (updated) repo : https://github.com/ClementPinard/pydata-nbsphinx-pandas-bug-example
Versions:
Sphinx = 5.3.0
jupyter = 1.0.0
pydata-sphinx-theme = 0.15.2
myst-nb = 1.0.0
In short, it would be nice to
The text was updated successfully, but these errors were encountered: