-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra vertical whitespace padding above h1 in theme v0.10.0 #955
Comments
+1 to revert #861. @choldgraf OK by you? You're the one who oversaw that one. |
That PR did a bunch of stuff right? Can we just revert the changes that added a UI bug? |
Any issues with #861 can be addressed separately. This issue can be closed with the 0.11 release and numpy/numpydoc@4d69444. |
It'd be nice not to have to annotate the rst file in the project with metadata in order to prevent the extra whitespace, so a solution within the theme itself would be preferable longer-term. Just wanted to mention that since this issue was closed! |
It's not clear to me what else needs to be done to resolve this - @rossbar or @jarrodmillman can you please clarify the steps we need to take to fix this problem? |
I just noticed that numpydoc's documentation looks strange with the latest pydata-sphinx-theme. I built the docs locally and can confirm that the extra vertical whitespace above the main title is present w/ v0.10.0 and later.
I went ahead and
bisect
ed which ID'ed #861 as the PR which introduced the behavior change.The text was updated successfully, but these errors were encountered: