Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra vertical whitespace padding above h1 in theme v0.10.0 #955

Closed
rossbar opened this issue Sep 27, 2022 · 6 comments · Fixed by numpy/numpydoc#434 or #1115
Closed

Extra vertical whitespace padding above h1 in theme v0.10.0 #955

rossbar opened this issue Sep 27, 2022 · 6 comments · Fixed by numpy/numpydoc#434 or #1115
Milestone

Comments

@rossbar
Copy link
Contributor

rossbar commented Sep 27, 2022

I just noticed that numpydoc's documentation looks strange with the latest pydata-sphinx-theme. I built the docs locally and can confirm that the extra vertical whitespace above the main title is present w/ v0.10.0 and later.

I went ahead and bisected which ID'ed #861 as the PR which introduced the behavior change.

@drammock
Copy link
Collaborator

+1 to revert #861. @choldgraf OK by you? You're the one who oversaw that one.

crossref to #904 which I think was also caused by #861

@choldgraf
Copy link
Collaborator

That PR did a bunch of stuff right? Can we just revert the changes that added a UI bug?

@jarrodmillman
Copy link
Collaborator

Any issues with #861 can be addressed separately. This issue can be closed with the 0.11 release and numpy/numpydoc@4d69444.

@rossbar
Copy link
Contributor Author

rossbar commented Oct 4, 2022

It'd be nice not to have to annotate the rst file in the project with metadata in order to prevent the extra whitespace, so a solution within the theme itself would be preferable longer-term. Just wanted to mention that since this issue was closed!

@jarrodmillman jarrodmillman reopened this Oct 6, 2022
@12rambau 12rambau modified the milestones: 0.12, 0.13 Nov 17, 2022
@choldgraf
Copy link
Collaborator

It's not clear to me what else needs to be done to resolve this - @rossbar or @jarrodmillman can you please clarify the steps we need to take to fix this problem?

@choldgraf
Copy link
Collaborator

I think that this is closeable by #1115 , at least I don't see any extra vertical whitespace in the numpy docs, and the extra secondary sidebar is going to be closed in #1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants