Add Matplotlib to gallery.yaml #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doc build looks good: https://pydata-sphinx-theme--1090.org.readthedocs.build/en/1090/examples/gallery.html AFAICT the other CI failures are expected (they don't run |
drammock
approved these changes
Dec 22, 2022
12rambau
approved these changes
Dec 22, 2022
|
Thanks for the clarification. Due to the doc failure I wasn't sure whether I would have to provide the .png or do some extra config. |
12rambau
added a commit
that referenced
this pull request
Dec 22, 2022
I validated #1090 even though I created this file. Gallery images are effectively not build during tests but we need to add the new missing image to the list to avoid failure of ALL downstream tests 😄
drammock
pushed a commit
that referenced
this pull request
Dec 23, 2022
I validated #1090 even though I created this file. Gallery images are effectively not build during tests but we need to add the new missing image to the list to avoid failure of ALL downstream tests 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.