Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that our header height was not properly being set, and this was causing
h1
andh2
titles to be too-close to the header when clicking anchor links.The problem was that we defined a
--pst-header-height
variable, but we did not force the header height to max-out at that variable. So the content of the header was causing it to expand in height. This made it look correct to us, but technically the header height wasn't the variable we had set. Because the anchors were set to a padding relative to the header height variable, their positioning was wrong.So this PR forces the header to have the height we want, and increases the height from
3rem
to4rem
which mimics the behavior we are used to. It also adds vertical padding to the navbar brand div so that it doesn't take too much space.Old behavior:
New behavior: