Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support leaflet maps in the theme #1112

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Jan 8, 2023

Fix #1110

There are several libs to bind Python and leaflet (folium, geemap, sepal-ui, ipyleaflet) and the dark theme was badly modifying there display in the dark theme.
These libs are widely used in the GIS community so I thought it worth our time to make sure they display nicely.

I used ipylealflet in the doc as it's the most commonly used and all the others are outputting the same tile class (leaflet-tile) so it should work the same. I created an extra file because some other surprises may rise in the future.

https://pydata-sphinx-theme--1112.org.readthedocs.build/en/1112/examples/pydata.html#ipyleaflet

Capture d’écran 2023-01-08 à 22 29 53

@12rambau 12rambau marked this pull request as ready for review January 8, 2023 21:41
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@choldgraf choldgraf merged commit 30a0b34 into pydata:main Jan 9, 2023
@12rambau 12rambau deleted the map branch January 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the theme add a background on leaflet tiles
2 participants