ENH: Add version warning bar #1335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have ypu checked the main comments of this thread #780 ? |
12rambau
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
I checked the code, I love it.
I first thought about the situation where one would use the "latest" version as a "stable" but you just need to set "stable" as a name in the switcher json to make it work. Also setting a different name in the conf.py file couldn't be used in a js compiled code.
Just to make sure, this will only work starting from the next version of the theme ? any previous version won't be able to show it ?
PS: the extra button can be coded in a follow-up PR
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional specialized announcement banner to warn users who are viewing versions of the docs other than the latest stable release. It can coexist with the generic announcement banner (it gets stacked above it) and is styled similarly except that it has the "danger" background color. Screenshot:
conf.py/html_contextcrossref: scientific-python/summit-2023#10 (comment)