Fix redirection for pages missing in other docs versions #1395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #844
related #1343
I think this should fix our redirection problems. The error was that we assumed that a
404
response would be an error, but as far as Javascript is concerned a404
response is still a real response! Now we check forresponse.ok
(meaning a response in the 200-299 range) and triage the URL accordingly. The try/catch is left in place as a fallback in case something actually did go wrong with the request/response (i.e., on local or PR builds when the request is blocked due to CORS restrictions).cc @lagru would appreciate if you could test this branch and report back